Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework tests marked as @pytest.skip when local chain is available for tests #206

Open
gabrielfior opened this issue Apr 18, 2024 · 1 comment

Comments

@gabrielfior
Copy link
Contributor

On this issue (#99 ) , we will implement a local chain (anvil based) that is started for testing (forking a local state from Gnosis), then tests are executed, then the chain is killed.

On that issue, some of the skipped tests were executed and the decorator was removed since they were executed successfully.
Other tests (marked with @pytest.mark.skip(reason=DEFAULT_REASON)) need reworking (see comments on each test). This rework is normally associated to usage of subgraphs or other tools, that don't get updated on the local chain - instead, directly reading from the local chain is the way to assert if state has been changed.

@gabrielfior
Copy link
Contributor Author

Depends on #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant