Remove wait_until_nonce_changed in favor of web3.eth.wait_for_transaction_receipt

[gabrielfior]

The function wait_until_nonce_changed is not needed, since the native method on the provider wait_for_transaction_receipt waits until the transaction has been included in the block and returns it, more reference here -> https://web3py.readthedocs.io/en/stable/web3.eth.html#web3.eth.Eth.wait_for_transaction_receipt

Hence we should update the usages (only tests at the moment).

[kongzii]

Note that we are already doing wait_for_transaction_receipt at

prediction-market-agent-tooling/prediction_market_agent_tooling/tools/web3_utils.py

Line 151 in f26e9de

receipt_tx = web3.eth.wait_for_transaction_receipt(send_tx, timeout=timeout)

, but for some reason, that wasn't enough and there were errors.

wait_until_nonce_changed did the trick, and because I didn't know that wait_for_transaction_receipt should be enough, I didn't care about it anymore 😄

So if wait_until_nonce_changed is removed, it's needed to test/debug it