Skip to content
This repository has been archived by the owner on Nov 19, 2023. It is now read-only.

preserving cls in chained promises is broken in nodejs >= 8.0 #14

Closed
gms1 opened this issue Jun 10, 2017 · 4 comments
Closed

preserving cls in chained promises is broken in nodejs >= 8.0 #14

gms1 opened this issue Jun 10, 2017 · 4 comments

Comments

@gms1
Copy link
Owner

gms1 commented Jun 10, 2017

see: nodejs/node#13583
@gms1
Copy link
Owner Author

gms1 commented Jun 10, 2017

NOTE: currently it is expected that the tests are failing, because the node version for this bug is not yet released, but another (npm?) issue is currently breaking the (travis) build:
gulpjs/gulp#1967
npm/npm#16677

@gms1 gms1 mentioned this issue Jun 15, 2017
Closed
@gms1
Copy link
Owner Author

gms1 commented Jun 16, 2017 •
edited
Loading

I had to delete the package-lock.json to be able to run the test on travis and to see the expected test results:
https://travis-ci.org/gms1/node-async-context/builds/243524322
now waiting for a node upgrade having a fix for this issue

@gms1
Copy link
Owner Author

gms1 commented Jun 16, 2017 •
edited
Loading

merged:
nodejs/node#13585
hopefully in next release: 8.1.3

@gms1
Copy link
Owner Author

gms1 commented Jul 21, 2017

fixed in nodejs 8.2.1

@gms1 gms1 closed this as completed Jul 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gms1