Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible workaround for search issues #134

Closed
amye opened this issue Jul 29, 2016 · 10 comments
Closed

Possible workaround for search issues #134

amye opened this issue Jul 29, 2016 · 10 comments

Comments

@amye
Copy link
Contributor

amye commented Jul 29, 2016

readthedocs/readthedocs.org#1088

I'm not sure if we're using the same json that this issue references, but we could work on overriding the searchbox.html to replace this with something else.

Assigning to @humblec so that he can tell me if I am crazy or if this could work.

@amye
Copy link
Contributor Author

amye commented Aug 2, 2016

@humblec, am I crazy? Could we overwrite this?

@humblec
Copy link
Contributor

humblec commented Aug 2, 2016

@amye finding out :) . Give me some time. I will get back.

@humblec
Copy link
Contributor

humblec commented Aug 2, 2016

@amye at present we use the standard templates of mkdocs and RTD (https://github.com/gluster/glusterdocs/blob/master/mkdocs.yml) without any customization . Looking at the thread, it seems to me that customizing the search could help us. @prashanthpai what do u think ?

@amye
Copy link
Contributor Author

amye commented Aug 5, 2016

Either a custom Google search or a more elaborate elasticsearch setup is where I am thinking, but that will require @mscherer's help.

@amye
Copy link
Contributor Author

amye commented Aug 5, 2016

Alternatively, @prashanthpai - this seems to be a confirmed workaround.
nodemcu/nodemcu-firmware@7dd89dd

@helmo
Copy link
Contributor

helmo commented Aug 25, 2017

I'm seeing 404's when I click in the search results on http://gluster.readthedocs.io

Would that also be solved by this? e.g. searching for 'brick' gives gluster - Brick Failure Detection as first result which returns a 404.

@nigelbabu
Copy link
Contributor

Ugh, that file hasn't existed on the repo since 2015 :(

@prashanthpai
Copy link
Contributor

This has been fixed to some extent by PR #255

@sankarshanmukhopadhyay
Copy link
Member

If #255 address some pertinent parts of this - can we either split this issue out and/or close the part which is done? Or, close this entire issue itself?

@nigelbabu
Copy link
Contributor

Yeah, this is safe to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants