Skip to content
This repository has been archived by the owner on Jul 7, 2020. It is now read-only.

gk_deploy: add --show-all switch to kubectl call #511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gk_deploy: add --show-all switch to kubectl call #511

wants to merge 1 commit into from

Conversation

crunis
Copy link

@crunis crunis commented Aug 24, 2018

Inside gk_deploy script, in check() function definition, when calling kubectl to check if one of the jobs has finished, the call is missing "--show-all" so it also shows jobs that are in Completed status, otherwise if the job has finished it is not listed and the script keeps waiting, eventually timing out.

Sample output:

$ kubectl get pods --no-headers -l job-name=heketi-storage-copy-job
No resources found, use --show-all to see completed objects.
$ kubectl get pods --show-all --no-headers -l job-name=heketi-storage-copy-job
heketi-storage-copy-job-8nfz7   0/1       Completed   0         19m

This change is Reviewable

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@nixpanic nixpanic requested a review from jarrpa August 25, 2018 17:37
@nixpanic
Copy link
Member

ok to test

@obnoxxx
Copy link
Contributor

obnoxxx commented Oct 19, 2018

This undoes half of PR #502 ...

@SaravanaStorageNetwork @jarrpa what to do here?

@obnoxxx
Copy link
Contributor

obnoxxx commented Oct 19, 2018

Just want to see whether the @centos-ci had not run when triggered by @nixpanic or if it just does not show up in the list of checks:

ok to test

@bjwschaap
Copy link

Please note that --show-all shouldn't be used anymore, since it is deprecated. The default behaviour of kubectl in current version is equivalent to the previous show all. See: kubernetes/kubernetes#67895

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants