Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transitive "runtime" dependencies are not included #347

Closed
kristofdho opened this issue Jun 17, 2021 · 3 comments
Closed

transitive "runtime" dependencies are not included #347

kristofdho opened this issue Jun 17, 2021 · 3 comments

Comments

@kristofdho
Copy link
Contributor

I have a project with transitive dependencies which are marked as runtime. These dependencies do not make it on the -imagecp of the native-image call.

It looks like they are not included in the returned collection of project.getArtifacts() here:

List<File> list = Stream.concat(project.getArtifacts().stream(), attachDependencies.stream())

The documentation of that call states:
Contents are lazily populated, so depending on what phases have run dependencies in some scopes won't be included
So maybe that has something to do with it?

I have no idea what a fix would look like, so sadly I can't provide a PR on the matter.

@jperedadnr
Copy link
Contributor

@kristofdho
Copy link
Contributor Author

Yes with 1.0.1.

The case seems to be:
gluonfx build project -> compile dependency -> runtime dependency

A direct runtime dependency does get included, a transitive runtime dependency doesn't. I threw together a quick example showcasing the issue: https://github.com/kristofdho/transitive-deps-gluonfx. Run instructions are included in the readme.

@jperedadnr
Copy link
Contributor

Should be fixed with #368. Feel free to reopen otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants