Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated components have TypeScript errors #2518

Open
1 of 6 tasks
benoit-ctrl opened this issue Oct 16, 2024 · 4 comments · May be fixed by #2475
Open
1 of 6 tasks

Generated components have TypeScript errors #2518

benoit-ctrl opened this issue Oct 16, 2024 · 4 comments · May be fixed by #2475
Assignees
Labels
bug Something isn't working

Comments

@benoit-ctrl
Copy link

benoit-ctrl commented Oct 16, 2024

Firstly, thanks for you work on Gluestack and for the community !
I encountered a TypeScript problem when using some Gluestack components so I decided to share it here.

Description

In some components like Heading and Icon there is TypeScript errors

CodeSandbox/Snack link

(none, failed to install Tailwind in Snack)

Steps to reproduce

  1. Install Heading or Icon component for example
  2. Check the generated files in your IDE with integrated TypeScript service or try to compile manually with tsc
  3. Observe reported TypeScript errors

gluestack-ui Version

2 (latest)

Platform

  • Expo
  • React Native CLI
  • Next
  • Web
  • Android
  • iOS

Other Platform

No response

Additional Information

  • TypeScript 5.6.2
  • React 18.2.0
image image
@benoit-ctrl benoit-ctrl added the bug Something isn't working label Oct 16, 2024
@Viraj-10
Copy link
Collaborator

Hey @benoit-ctrl, This issues will be fixed in #2475.

@Viraj-10 Viraj-10 linked a pull request Oct 17, 2024 that will close this issue
3 tasks
@benoit-ctrl
Copy link
Author

Hello @Viraj-10, thank you for your answer👌 !

I have a question, since Gluestack is a "copy-paste components" library the only way to get update is to re-generate components after a library update ?
If so, then if we've already customized Gluestack components it's starts to be more complicated I suppose

@Viraj-10
Copy link
Collaborator

@benoit-ctrl, Yes, You should just create a branch from you main and add all the installed components.
you will be able to see all the changes through diff. discard all the unwanted changes and commit your changes.

We know this is a pain point for all the customised components. we are planning to split style files from components. so, it would be easier to update.

Also we will be publishing Diff with every release and releases would be on weekly bases and planning on adding update command.

@benoit-ctrl
Copy link
Author

@Viraj-10 Thank you for your detailed answer, I understand better now 😁

It's a great idea trying to support a little the updating process through tools, if it doesn't have too much impact on the other milestones of the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants