Skip to content

Use pixel matrix for component ID mapping #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Use pixel matrix for component ID mapping #401

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77662ea
Use pixel matrix to get order mapping between components.
Carifio24 Oct 17, 2025
a06d119
We need to check that the argmax index actually gives a true value.
Carifio24 Oct 17, 2025
cec940b
Codestyle fixes.
Carifio24 Oct 17, 2025
ac4f2fb
Order won't be None now, so simplify check.
Carifio24 Oct 17, 2025
0104b33
Rather than look for linked components, just let FRB calculation fail…
Carifio24 Oct 20, 2025
5192ba5
Use pixel matrix from data for a subset layer.
Carifio24 Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions glue_vispy_viewers/volume/layer_artist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from matplotlib.colors import ColorConverter

from glue.core.data import Subset, Data
from glue.core.link_manager import equivalent_pixel_cids
from glue.core.link_manager import pixel_cid_to_pixel_cid_matrix
from glue.core.exceptions import IncompatibleAttribute
from glue.core.fixed_resolution_buffer import ARRAY_CACHE, PIXEL_CACHE
from .colors import get_mpl_cmap, get_translucent_cmap
Expand All @@ -31,17 +31,29 @@ def layer_artist(self):
def viewer_state(self):
return self._viewer_state()

def _pixel_cid_order(self):
data = self.layer_artist.layer
if isinstance(self.layer_artist.layer, Subset):
data = data.data
mat = pixel_cid_to_pixel_cid_matrix(self.viewer_state.reference_data,
data)
order = []
for i in range(mat.shape[1]):
idx = np.argmax(mat[:, i])
order.append(idx if mat[idx, i] else None)
return order

@property
def shape(self):

order = equivalent_pixel_cids(self.viewer_state.reference_data,
self.layer_artist.layer)
order = self._pixel_cid_order()

try:
x_axis = order.index(self.viewer_state.x_att.axis)
y_axis = order.index(self.viewer_state.y_att.axis)
z_axis = order.index(self.viewer_state.z_att.axis)
except (AttributeError, ValueError):
self.layer_artist.disable('Layer data is not fully linked to reference data')
return 0, 0, 0

if isinstance(self.layer_artist.layer, Subset):
Expand All @@ -58,14 +70,9 @@ def compute_fixed_resolution_buffer(self, bounds=None):
if self.layer_artist is None or self.viewer_state is None:
return np.broadcast_to(0, shape)

order = equivalent_pixel_cids(self.viewer_state.reference_data,
self.layer_artist.layer)
reference_axes = [self.viewer_state.x_att.axis,
self.viewer_state.y_att.axis,
self.viewer_state.z_att.axis]
if order is not None and not set(reference_axes) <= set(order):
self.layer_artist.disable('Layer data is not fully linked to x/y/z attributes')
return np.broadcast_to(0, shape)

# For this method, we make use of Data.compute_fixed_resolution_buffer,
# which requires us to specify bounds in the form (min, max, nsteps).
Expand Down
Loading