Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the GeneratePosOrder service object be refactored? #55

Open
DanielWright opened this issue Oct 17, 2016 · 0 comments
Open

Should the GeneratePosOrder service object be refactored? #55

DanielWright opened this issue Oct 17, 2016 · 0 comments

Comments

@DanielWright
Copy link
Contributor

The GeneratePosOrder service object is a dense and complex object. It relies on a lot of things going right to work correctly, and doesn't recover from failures very gracefully. It's also tightly coupled to how orders are processed, and thus can be painful to integrate. Finally, it's murderous to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant