Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatMessage texts are enclosed in <span> elements - change element / remove it? #89

Open
ieugen opened this issue May 10, 2019 · 2 comments

Comments

@ieugen
Copy link

ieugen commented May 10, 2019

Hello,

Is there any way of changing the to another element or even better - remove the enclosing element ?

I think React 16 allows for having components that do not need enclosing tags.

Thanks,

@rxaviers
Copy link
Member

I am open to remove and/or use React.Fragments when needed being cautious to update react.js peer dependency if necessary. PR welcome. Thanks

@ieugen
Copy link
Author

ieugen commented Jun 10, 2019

Hello @rxaviers , We would like to fix a bug (feature?!). However I've noticed that the project has open PR's since 2015 - 2017 . I'm not that keen on providing a PR without a chance of it reaching upstream.

Could you please provide some feedback for this? And maybe merge the outstanding open PR's ?!
I've noticed some of the changes are yours.

As a plan, I would like to:

  • update dependencies
  • implement feature/bug
  • write tests

The current status is like this:

added 515 packages from 631 contributors and audited 4137 packages in 32.467s
found 229 vulnerabilities (4 low, 220 moderate, 5 high)
  run `npm audit fix` to fix them, or `npm audit` for details

ieugen@daos-sv /react-globalize                                                                     master
⚡ ncu 
Using /react-globalize/package.json
[..................] / :
 globalize                     1.1.x  →    1.4.x 
 babel-eslint                 ^8.0.1  →  ^10.0.1 
 cldrjs                       ^0.4.3  →   ^0.5.1 
 eslint                      ^1.10.3  →  ^5.16.0 
 eslint-config-defaults       ^7.1.1  →   ^9.0.0 
 eslint-plugin-react         ^3.11.2  →  ^7.13.0 
 mocha                        ^4.0.0  →   ^6.1.4 
 rollup                      ^0.50.0  →  ^1.14.6 
 rollup-plugin-babel          ^3.0.2  →   ^4.3.2 
 rollup-plugin-node-resolve   ^3.0.0  →   ^5.0.1 

The following dependencies are satisfied by their declared version range, but the installed versions are behind. You can install the latest versions without modifying your package file by using npm update. If you want to update the dependencies in your package file anyway, run ncu -a.

 react                    ^16.0.0  →  ^16.8.6 
 chai                      ^4.1.2  →   ^4.2.0 
 cldr-data                   >=25  →     >=35 
 enzyme                    ^3.0.0  →  ^3.10.0 
 enzyme-adapter-react-16   ^1.0.1  →  ^1.14.0 
 react-dom                ^16.0.0  →  ^16.8.6 
 react-test-renderer      ^16.0.0  →  ^16.8.6 

Run ncu with -u to upgrade package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants