Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive on G001/G004 when not using a stdlib logger? #71

Open
q-aaronzolnailucas opened this issue Oct 13, 2023 · 0 comments
Open

Comments

@q-aaronzolnailucas
Copy link

q-aaronzolnailucas commented Oct 13, 2023

A contrived minimal example that triggers for me:

class Foo:
    def info(arg) -> None:
        ...

foo: Foo = Foo()

world = "world"
foo.info("hello {world}".format(world=world))
foo.info(f"hello {world}")

Gives a G001 and G004 even though foo is quite clearly not a logger, just an object with an info method.

If I update the calls to use the extra keyword arg as flake8-logging-format requests, clearly this results in a runtime error calling Foo.info.

I ran into this issue in a non-trivial way with code which was making calls to a java logger through pyspark, which also doesn't support extra.

Could G001 be ignored whenever the object is clearly typehinted not to be a logging.Logger?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant