-
Notifications
You must be signed in to change notification settings - Fork 190
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformatting breaks certain HTML entities #1283
Comments
@pzuraq what are your thoughts on this one? it's a big problem for me and I'd like to contribute if it's a non-trivial fix. |
Definitely would be open to a fix, unsure exactly where this would be transforming in the system itself, likely when we first read the text node's content? |
@jpike88 - We explicitly provide modes that disable entity parsing, seems like they should be leveraging that? |
See #938 |
Prettier uses that setting. Named entities are preserved, numeric character reference aren't. |
This use case is because I have large custom font libraries consisting of symbols. |
Thank you! I believe that #1284 will fix this (added your snippet as a test case to confirm). |
cheers! |
I use the VSCode extension
handlebars-formatter
(https://github.com/mfeckie/handlebars-formatter) which relies on prettier (https://github.com/prettier/prettier) which in turn relies on glimmer.I tried to format this:
That entity is valid HTML and shouldn't be stripped... but it gets changed to this:
The text was updated successfully, but these errors were encountered: