Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resolves or rejects (assertions for promises) #73

Open
Pet3ris opened this issue Aug 16, 2020 · 3 comments
Open

Support resolves or rejects (assertions for promises) #73

Pet3ris opened this issue Aug 16, 2020 · 3 comments

Comments

@Pet3ris
Copy link

Pet3ris commented Aug 16, 2020

Jest seems to have good support for promises with assertions: https://jestjs.io/docs/en/asynchronous#promises, which may be useful to provide.

@glennsl
Copy link
Owner

glennsl commented Aug 16, 2020

There's already testPromise. Do you think that's not sufficient?

@Pet3ris
Copy link
Author

Pet3ris commented Aug 16, 2020

@glennsl it doesn't seem as nice / aligned syntactically but functionally sufficient for sure!

@glennsl
Copy link
Owner

glennsl commented Aug 17, 2020

I'm not really a fan of offering multiple ways of doing something, but since it's a pattern in jest, and as long as it's feasible, I'm not opposed to it. And at least API-wise it seems like it should line up well with the bs-jest approach of requiring a single assertion to be returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants