-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow string concatenation when defining const values #3208
Comments
Just wondering why this isn't allowed? Is there a reason (since it seems fairly reasonable) or was it just left to be implemented later? |
Thank you! Good suggestion. @slightlybelowzen It's just something no one has implemented. The stuff that people decide to work on is the stuff that gets done. |
Fair enough, I could try to hack something together this weekend, see if I get anywhere😀 |
Wonderful! Thank you |
I started looking into that. Not sure if @slightlybelowzen has started something too but it doesn't matter too much to me if my code doesn't go anywhere, this is a pretty cool task to start getting familiar with the code. pub const foo = 5
pub const foo_bar = foo + 5 |
Just concatenation for now as it does not require compile time code execution to implement. |
why doesn't concatenation require compile time code execution? we should inline the concatenation operation? If so then what's the difference with inlining other operations? |
Because that's how Erlang works. |
yeah I don't know I was more thinking about the javascript part. sorry about the questions, I was just trying to understand a bit more. I will try to make a PR anyway, we'll see |
Thank you 💜 |
This is currently not valid syntax:
It would be great if this would work!
The text was updated successfully, but these errors were encountered: