Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element Research rnn benchmark ++ #5

Merged
merged 3 commits into from
Mar 30, 2016
Merged

Conversation

nicholas-leonard
Copy link
Contributor

Changes :

  • simple rnn is faster (uses JoinTable + one Linear)
  • uses torch.Timer() instead of os.clock() (more precise)
  • calls cutorch.synchronize before measuring time. (Don't remember how to do this for theano, but it should be done as well).
  • measures setup time (torch and theano)

It would be nice if the benchmarks included the setup time as well.
Please update the benchmarks.

@glample
Copy link
Owner

glample commented Mar 30, 2016

Thanks for the changes! This RNN is much faster.
The warming part in Theano doesn't seem to make a difference, but is clearly needed in torch (I guess it's because the sequencer needs to clone the recurrentModule when it receives the first batch?). I forgot to put it in the code, but in these benchmarks I was already running a forward call before starting the timer (otherwise the forward time was clearly wrong), so I basically still have the same running times for LSTM.

@nicholas-leonard
Copy link
Contributor Author

@glample Yeah the warming part isn't necessary for theano. But since the "setup" time in torch implies a forward/backward, I wanted to include it in theano's setup time just to be fair. It would be really nice to include this setup time in the README as this may be theano's hidden weakness, although they have made great strides to reduce compile time since I last used it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants