Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @glample,
This PR provides the following updates:
input
andtarget
batch. This allows the benchmarking of huge networks as otherwise thexValues
tensor was so big that it would blow up the memory.seqlen x batchsize x hiddensize
instead ofbatchsize x seqlen x hiddensize
this gives a slight speedup to all implementations and is the natural way to present sequential data as it makes the step-wise tensors contiguous in memory.hiddensize = inputsize
. This is the usual use-case for RNN/LSTMs.hiddensize
of 128, 512 and 1024,batchsize
of 32 and 128 as mentioned in Benchmark hidden sizes that give better efficiency and bigger batches #9 .