Skip to content

Improve right & other alignments in gl-scatter3d #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2018
Merged

Improve right & other alignments in gl-scatter3d #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7774cd8
fix issue 2871 - right alignments
archmoj Oct 30, 2018
b083e84
corrected package lock
archmoj Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 7 additions & 6 deletions pointcloud.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,8 +528,6 @@ proto.update = function(options) {
var idArray = pool.mallocUint32(vertexCount)

if(vertexCount > 0) {
var textOffset = [0,alignment[1]]

var triOffset = 0
var lineOffset = triVertexCount
var color = [0,0,0,1]
Expand Down Expand Up @@ -657,10 +655,13 @@ proto.update = function(options) {
}

//Calculate text offset
if(alignment[0] < 0) {
textOffset[0] = alignment[0] * (1+glyphBounds[1][0])
} else if(alignment[0] > 0) {
textOffset[0] = -alignment[0] * (1+glyphBounds[0][0])
var textOffset = [alignment[0], alignment[1]]
for(var j=0; j<2; ++j) {
if(alignment[j] > 0) {
textOffset[j] *= (1-glyphBounds[0][j])
} else if(alignment[j] < 0) {
textOffset[j] *= (1+glyphBounds[1][j])
}
}

//Write out inner marker
Expand Down