Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic imports for loading STL and Collada Loader #81

Open
gkjohnson opened this issue Oct 18, 2018 · 2 comments
Open

Use dynamic imports for loading STL and Collada Loader #81

gkjohnson opened this issue Oct 18, 2018 · 2 comments
Labels

Comments

@gkjohnson
Copy link
Owner

#80 moved over to use es6 imports but the STL and Collada loader will always be included in a build because they are included at the top of the file. The right way to handle this is to use the dynamic import() function.

This will implies code splitting for builds and adds complications for converting to a umd format because the imported file is external.

Rollup supports the --experimentalDynamicImport flag so that may be worth investigating.

@gkjohnson gkjohnson added this to the Release 0.9.0 milestone Jun 25, 2020
@gkjohnson
Copy link
Owner Author

@gkjohnson gkjohnson removed this from the Release 0.9.0 milestone Oct 8, 2020
@gkjohnson
Copy link
Owner Author

Rollup supports this, Parcel supports it, and Webpack will support it more cleanly in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant