Skip to content
This repository has been archived by the owner on Jul 14, 2020. It is now read-only.

Standardize on dest_ or destination_, but not both #17

Open
gjtorikian opened this issue Feb 12, 2015 · 0 comments
Open

Standardize on dest_ or destination_, but not both #17

gjtorikian opened this issue Feb 12, 2015 · 0 comments

Comments

@gjtorikian
Copy link
Owner

Both prefixes are currently being used:

@destination_repo = params[:dest_repo]
halt 500, 'Missing `dest_repo` argument' if @destination_repo.nil?
@payload = JSON.parse(payload_body)
halt 202, "Payload was not for master, was for #{@payload['ref']}, aborting." unless master_branch?(@payload)
@squash = params[:squash]
# keep some important vars
process_payload(@payload)
@destination_hostname = params[:destination_hostname] || 'github.com'

That's silly. Pick one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant