Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gjtorikian/html-proofer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.0.9
Choose a base ref
...
head repository: gjtorikian/html-proofer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.0.10
Choose a head ref
  • 20 commits
  • 28 files changed
  • 6 contributors

Commits on May 8, 2024

  1. simplify

    @gjtorikian
    gjtorikian committed May 8, 2024

    Verified

    This commit was signed with the committer’s verified signature.
    gjtorikian Garen Torikian
    SSH Key Fingerprint: IczF2kzeRYN/j9cSsPXeZosnm4pv7mPL1BM5wOZ63Rg
    Verified
    Learn about vigilant mode
    Copy the full SHA
    ee2c50e View commit details

Commits on May 13, 2024

  1. Fixup typhoeus arg usage in README

    @gionn
    gionn authored May 13, 2024
    Loading
    Loading status checks…

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    cabd528 View commit details

  2. fix typo

    @gionn
    gionn committed May 13, 2024
    Loading
    Loading status checks…
    Copy the full SHA
    3925d53 View commit details

  3. Merge pull request #841 from gionn/patch-1 

    Fixup typhoeus arg usage in README
    @gjtorikian
    gjtorikian authored May 13, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    3aa6347 View commit details

Commits on May 23, 2024

  1. Added test for UTF-8 encoded internal links 

    There wasn't a specific test for this, and it fails on some setups.

The link in the fixture is a direct copy-paste from one that fails on my project.

But the test passes on this test suite... So there is something else going on.

Relates to #757
    @ahpook
    ahpook committed May 23, 2024
    Copy the full SHA
    4958ecb View commit details

  2. Reproducible case for anchor link encoding failures 

    Looking a little deeper into the source code of the failures, I noticed that not _all_ the non-ASCII links were failing, only some of them. The site gets built with relative links between pages, and it was links to another page with a "../page/#hash" syntax which failed.

This commit adds a test directory which mimics that structure and reliably reproduces the error... I think!
    @ahpook
    ahpook committed May 23, 2024
    2
    Copy the full SHA
    5534884 View commit details

  3. Fix trailing whitespace

    @ahpook
    ahpook committed May 23, 2024
    Loading
    Loading status checks…
    Copy the full SHA
    3748112 View commit details

Commits on May 29, 2024

  1. Merge pull request #842 from ahpook/check-utf8-relative-anchors 

    Check utf8 relative anchors
    @gjtorikian
    gjtorikian authored May 29, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    4cc3f62 View commit details

Commits on Aug 2, 2024

  1. Fix variable assignment in index.php

    @MakWigglz
    MakWigglz committed Aug 2, 2024
    Loading
    Loading status checks…
    Copy the full SHA
    87c5565 View commit details

Commits on Aug 3, 2024

  1. Merge pull request #845 from MakWigglz/main 

    Fix variable assignment in index.php
    @gjtorikian
    gjtorikian authored Aug 3, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    3800c70 View commit details

Commits on Aug 19, 2024

  1. Correct README example

    @gjtorikian
    gjtorikian committed Aug 19, 2024
    Loading
    Loading status checks…

    Verified

    This commit was signed with the committer’s verified signature.
    gjtorikian Garen Torikian
    SSH Key Fingerprint: IczF2kzeRYN/j9cSsPXeZosnm4pv7mPL1BM5wOZ63Rg
    Verified
    Learn about vigilant mode
    Copy the full SHA
    f983709 View commit details

  2. Merge pull request #847 from gjtorikian/fix-docs 

    Correct README example
    @gjtorikian
    gjtorikian authored Aug 19, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    5903360 View commit details

Commits on Feb 14, 2025

  1. Handle multiple srcsets when first is remote

    @paulroub
    paulroub committed Feb 14, 2025
    Loading
    Loading status checks…
    Copy the full SHA
    099ea26 View commit details

Commits on Feb 21, 2025

  1. expect a UA

    @gjtorikian
    gjtorikian committed Feb 21, 2025

    Verified

    This commit was signed with the committer’s verified signature.
    gjtorikian Garen Torikian
    SSH Key Fingerprint: IczF2kzeRYN/j9cSsPXeZosnm4pv7mPL1BM5wOZ63Rg
    Verified
    Learn about vigilant mode
    Copy the full SHA
    f81132f View commit details

  2. update rubocop

    @gjtorikian
    gjtorikian committed Feb 21, 2025

    Verified

    This commit was signed with the committer’s verified signature.
    gjtorikian Garen Torikian
    SSH Key Fingerprint: IczF2kzeRYN/j9cSsPXeZosnm4pv7mPL1BM5wOZ63Rg
    Verified
    Learn about vigilant mode
    Copy the full SHA
    cd63db6 View commit details

  3. lint

    @gjtorikian
    gjtorikian committed Feb 21, 2025

    Verified

    This commit was signed with the committer’s verified signature.
    gjtorikian Garen Torikian
    SSH Key Fingerprint: IczF2kzeRYN/j9cSsPXeZosnm4pv7mPL1BM5wOZ63Rg
    Verified
    Learn about vigilant mode
    Copy the full SHA
    9a870f6 View commit details

  4. 💎 5.0.10

    @gjtorikian
    gjtorikian committed Feb 21, 2025
    Loading
    Loading status checks…

    Verified

    This commit was signed with the committer’s verified signature.
    gjtorikian Garen Torikian
    SSH Key Fingerprint: IczF2kzeRYN/j9cSsPXeZosnm4pv7mPL1BM5wOZ63Rg
    Verified
    Learn about vigilant mode
    Copy the full SHA
    f44aa4c View commit details

  5. Merge pull request #851 from paulroub/srcset-sizes-fail 

    Handle multiple srcsets when first is remote (fixes #850)
    @gjtorikian
    gjtorikian authored Feb 21, 2025
    Loading
    Loading status checks…

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    3ecb630 View commit details

  6. [skip test] update changelog

    @gjtorikian @github-actions
    gjtorikian authored and github-actions[bot] committed Feb 21, 2025
    Loading
    Loading status checks…
    Copy the full SHA
    117fc37 View commit details

  7. Merge pull request #852 from gjtorikian/release/v5.0.10 

    [skip test] Release v5.0.10
    @gjtorikian
    gjtorikian authored Feb 21, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    527109a View commit details
Showing with 488 additions and 121 deletions.
  1. +2 −2 .github/workflows/tag_and_release.yml
  2. +6 −3 .rubocop.yml
  3. +15 −0 CHANGELOG.md
  4. +93 −94 README.md
  5. +1 −1 lib/html_proofer/attribute/url.rb
  6. +12 −12 lib/html_proofer/check/images.rb
  7. +1 −1 lib/html_proofer/log.rb
  8. +1 −1 lib/html_proofer/version.rb
  9. +1 −1 spec/html-proofer/cache_spec.rb
  10. +6 −0 spec/html-proofer/check/images_spec.rb
  11. +6 −0 spec/html-proofer/check/links_spec.rb
  12. +1 −1 spec/html-proofer/cli_spec.rb
  13. +1 −1 spec/html-proofer/fixtures/cache/version_2/.internal_and_external.json
  14. +1 −1 spec/html-proofer/fixtures/cache/version_2/.recheck_external_failure.json
  15. +1 −1 spec/html-proofer/fixtures/cache/version_2/.removed_link.json
  16. +1 −1 spec/html-proofer/fixtures/cache/version_2/.runner.json
  17. +12 −0 spec/html-proofer/fixtures/images/srcset_picture_remote_sizes.html
  18. +1 −1 spec/html-proofer/fixtures/links/folder-php/index.php
  19. +8 −0 spec/html-proofer/fixtures/links/hash_nonascii_dir/source/index.html
  20. +10 −0 spec/html-proofer/fixtures/links/hash_nonascii_dir/target/index.html
  21. +25 −0 ...er/fixtures/vcr_cassettes/fixtures/links_extensions_xhtml_foo_log_level_error_type_directory_.yml
  22. +25 −0 .../html-proofer/fixtures/vcr_cassettes/links/bad_external_links_html_log_level_error_type_file_.yml
  23. +25 −0 ...tml-proofer/fixtures/vcr_cassettes/links/broken_link_external_html_log_level_error_type_file_.yml
  24. +87 −0 spec/html-proofer/fixtures/vcr_cassettes/links/empty_href_html_log_level_error_type_file_.yml
  25. +25 −0 .../html-proofer/fixtures/vcr_cassettes/links/file_foo_extensions_foo_log_level_error_type_file_.yml
  26. +71 −0 ...-proofer/fixtures/vcr_cassettes/links/non_standard_characters_html_log_level_error_type_file_.yml
  27. +25 −0 spec/html-proofer/fixtures/vcr_cassettes/links/source_html_log_level_error_type_file_.yml
  28. +25 −0 ...proofer/fixtures/vcr_cassettes/scripts/script_broken_external_html_log_level_error_type_file_.yml
4 changes: 2 additions & 2 deletions .github/workflows/tag_and_release.yml
View file
Original file line number Diff line number Diff line change
@@ -20,5 +20,5 @@ jobs:
with:
gem_name: html-proofer
version_filepath: lib/html_proofer/version.rb
prepare: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }}
release: ${{ (github.event.pull_request.merged == true) && (contains(github.event.pull_request.labels.*.name, 'release')) }}
prepare: ${{ github.event_name == 'push' }}
release: ${{ github.event_name == 'workflow_dispatch' || ((github.event.pull_request.merged == true) && (contains(github.event.pull_request.labels.*.name, 'release'))) }}
9 changes: 6 additions & 3 deletions .rubocop.yml
View file
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@ inherit_gem:
rubocop-standard:
- config/default.yml

require:
plugins:
- rubocop-rspec

Naming/FileName:
@@ -14,8 +14,11 @@ RSpec/AnyInstance:
RSpec/ExampleLength:
Enabled: false

RSpec/FilePath:
Enabled: false
# RSpec/SpecFilePathFormat:
# Enabled: false

# RSpec/SpecFilePathSuffix:
# Enabled: false

RSpec/MultipleExpectations:
Enabled: false
15 changes: 15 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
# [v5.0.10] - 21-02-2025
## What's Changed
* Fixup typhoeus arg usage in README by @gionn in https://github.com/gjtorikian/html-proofer/pull/841
* Check utf8 relative anchors by @ahpook in https://github.com/gjtorikian/html-proofer/pull/842
* Fix variable assignment in index.php by @MakWigglz in https://github.com/gjtorikian/html-proofer/pull/845
* Correct README example by @gjtorikian in https://github.com/gjtorikian/html-proofer/pull/847
* Handle multiple srcsets when first is remote (fixes #850) by @paulroub in https://github.com/gjtorikian/html-proofer/pull/851

## New Contributors
* @gionn made their first contribution in https://github.com/gjtorikian/html-proofer/pull/841
* @ahpook made their first contribution in https://github.com/gjtorikian/html-proofer/pull/842
* @MakWigglz made their first contribution in https://github.com/gjtorikian/html-proofer/pull/845
* @paulroub made their first contribution in https://github.com/gjtorikian/html-proofer/pull/851

**Full Changelog**: https://github.com/gjtorikian/html-proofer/compare/v5.0.9...v5.0.10
# [v5.0.9] - 07-05-2024

## What's Changed
Loading