-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert_filter only executed when node_filters are present #391
Comments
Just let me know if you like to have a PR for that – only if this is unintended behaviour of course. In practice this isn't an issue for me since I'll be using some |
Hey @grekko, I'm in the process of updating to v3 and just encountered the same issue. I was wondering if this was an intentional behavior. In my case, I only need the |
Completely unintentional—thank you for the report. Will be fixed monetarily in 3.0.2! |
Hey hey, I'm playing around with
html-pipeline
and noticed that the following snippet does not run theconvert_filter
:vs. when defining any node_filter like so:
AFAIU the
html
-result will not be used unless any@node_filters
are present. Seehtml-pipeline/lib/html_pipeline.rb
Lines 168 to 179 in 74766e7
The text was updated successfully, but these errors were encountered: