Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate a version for activesupport that has support/receives security patches (>= 6?) #367

Closed
alaendle opened this issue Dec 14, 2022 · 2 comments
Labels

Comments

@alaendle
Copy link

Guess this is a controversial issue - and I absolutely not an expert for the ruby ecosystem - but I wonder if it wouldn't be preferable to enforce users of the package to also use a supported activesupport version? (>=6?)

gem.add_dependency 'activesupport', '>= 2'

In my example this is the online dependency into rails/activesupport - so bundle install chooses a 3.x version of activesupport for me - bringing in potential vulnerabilities (my guess is they aren't exploitable through html-pipeline, but nonetheless I see no reason to have/indicate support for unsecure/outdated versions). Sure this can be worked around by manually touching gemfile.lock or adding an artificial direct unnecessary dependency to activesupport - but is this the preferred way or should this package require a newer version?

End-of-life rails

@gjtorikian gjtorikian added the v3 label Dec 14, 2022
@gjtorikian
Copy link
Owner

Makes sense. I'll add it to the upcoming v3 release which will introduce a bunch of modernity.

@gjtorikian
Copy link
Owner

A new (beta) release of HTML-Proofer has been released, v3.0.0.pre1. I tried to go back and address all the issues in this repo.

activesupport was actually not a strictly necessary dependency, and as such, I've removed it.

Repository owner locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants