Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MathML elements to whitelist #336

Closed
alexmilowski opened this issue Sep 28, 2020 · 4 comments
Closed

Add MathML elements to whitelist #336

alexmilowski opened this issue Sep 28, 2020 · 4 comments

Comments

@alexmilowski
Copy link

In looking at lib/html/pipeline/sanitization_filter.rb, I see that all the MathML elements are missing from the whitelist. Presentational MathML is certainly innocuous markup. It could be added to this list without having harmful side effects.

Meanwhile, MathML is part of HTML5 and it is essential for creating accessible web pages with embedded Mathematics.

I'd be happy to provide a list of elements to add to the whitelist.

@gjtorikian
Copy link
Owner

Sounds good to me.

@fred-wang
Copy link

@alexmilowski
Copy link
Author

I should just write a PR for this.

@gjtorikian
Copy link
Owner

A new (beta) release of HTML-Proofer has been released, v3.0.0.pre1. I tried to go back and address all the issues in this repo. For this specific issue, I've opted to keep the sanitization process the same. However, downstream consumers can easily make any change they want to the sanitization process; see the updated README for more information.

Repository owner locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants