Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the list of commonmarker extensions with custom renderer is broken #321

Closed
hannesfostie opened this issue Nov 14, 2019 · 2 comments · Fixed by #322
Closed

Changing the list of commonmarker extensions with custom renderer is broken #321

hannesfostie opened this issue Nov 14, 2019 · 2 comments · Fixed by #322

Comments

@hannesfostie
Copy link
Contributor

Hey,

A while back @gjtorikian assisted in allowing us to choose a custom renderer for the MarkdownFilter. He also explained how to remove extensions (in our case, tagfilter).

I just discovered that when using these features together, tagfilter is not properly removed.

I added a working and a broken test for this in my branch https://github.com/hannesfostie/html-pipeline/tree/hf/extensions-issue

I'll spend a bit longer to try and figure this out but wanted to create the issue since you're much more familiar with the code, just in case you immediately knew where to look. If I find a solution I'll share it here and create a proper PR for it.

@gjtorikian
Copy link
Owner

My mistake here--I forgot to pass unsafe as an option along with the renderer, too 🤦‍♂ 4e997bf

@hannesfostie
Copy link
Contributor Author

Aha! That makes perfect sense. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants