Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5 support #252

Closed
connorshea opened this issue Apr 24, 2016 · 8 comments
Closed

Rails 5 support #252

connorshea opened this issue Apr 24, 2016 · 8 comments

Comments

@connorshea
Copy link

Will html-pipeline be updated with ActiveSupport 5 and therefore Rails 5 support any time soon?

@jch
Copy link
Contributor

jch commented Apr 25, 2016

I haven't had time to set up tests with a new gemfile. It shouldn't be difficult though.

@connorshea
Copy link
Author

Awesome! Rails 5.0.0.beta4 just came out, and allegedly rc1 will be coming in the next few weeks. It'd be great to have support for it :)

@jaykilleen
Copy link

@connorshea what sort of issues are you having? I am also running Rails 5.0.0.beta4 and am getting the syntax highlighting and tables don't appear to be working. Not sure if it is me though :/

@connorshea
Copy link
Author

@jaykilleen Unfortunately because the gemspec requires activesupport < 5 we can't use it without forking the gem and changing that ourselves. We haven't been able to test it with Rails 5 yet because of other gems as well, despite my having spent the last few months trying to update gems >.<

@n-rodriguez
Copy link

hi there! any news?

@jch jch closed this as completed in #257 Jul 11, 2016
@n-rodriguez
Copy link

Thanks!

@JuanitoFatas
Copy link
Contributor

@connorshea Please try 2.4.2 on Rails 5, please report if any problem, thank you.

@connorshea
Copy link
Author

Thank you @JuanitoFatas! We'll try upgrading and report back if there are any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants