Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji <img> tags does not pass W3C validationg #234

Closed
FiveYellowMice opened this issue Nov 25, 2015 · 6 comments
Closed

Emoji <img> tags does not pass W3C validationg #234

FiveYellowMice opened this issue Nov 25, 2015 · 6 comments

Comments

@FiveYellowMice
Copy link

I use jekyl/jemoji to generate emojis. However the <img> tags use align attribute which is deprecated.

How about using style attribute instead?

I've opened an issue on jekyll/jemoji#30.

@simeonwillbanks
Copy link
Contributor

EmojiFilter#emoji_image_tag contains the HTML.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img

align Deprecated since HTML4.01, Obsolete since HTML5
Use the vertical-align CSS property
The alignment of the image with respect to its surrounding context.

I'm 👍 removing. 😄

@kbrock
Copy link
Contributor

kbrock commented Nov 25, 2015

For some ideas around the css, you may want to look here

good luck

@adammacias
Copy link

👍

@borisschapira
Copy link

Hello! First, thanks to the people maintaining this. I'm gonna try to help, but I'm not sure I can. About this issue, may I propose another path: keeping the current markup (for backward compatibility) but allowing user to propose a custom markup ? That way, jekyll/jemoji could offer the capacity to users to propose their own template.

@rajsite
Copy link

rajsite commented Jun 19, 2016

@borisschapira That would be awesome, I just reported this issue jekyll/jemoji#42 but I'm guessing the templating you propose would need to be implemented first.

To briefly re-state that issue, templating would be useful to enable using emoji with AMP HTML which requires using the amp-img tag instead of img.

@JuanitoFatas
Copy link
Contributor

<img> tag attributes now can be override, please see #258.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants