Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SmartQuotes filter #220

Closed
benbalter opened this issue Sep 17, 2015 · 3 comments
Closed

Add SmartQuotes filter #220

benbalter opened this issue Sep 17, 2015 · 3 comments

Comments

@benbalter
Copy link
Contributor

There's a few scenarios where we'd prefer content be published with smart quotes, and based on our implementation, the most elegant solution would be to bake the smartification into HTML Pipeline.

It looks like Rubypants is a Ruby port of SmartyPants, the library used by things like WordPress.

Before I went too far down the 🐰 hole, wanted to gauge interest in a PR adding a SmartQuotes filter that used Ruby pants as an optional dependency.

/cc @cameronmcefee

@jch
Copy link
Contributor

jch commented Sep 17, 2015

If you do decide to build it, I'd recommend building as a separate gem and linking to it from the readme. We've been avoiding adding more dependencies to this gem and also it's easier for the original author to maintain it.

@benbalter
Copy link
Contributor Author

I'd recommend building as a separate gem and linking to it from the readme.

Just to confirm, you're suggesting I create a gem that adds a new filter to HTML pipeline?

@jch
Copy link
Contributor

jch commented Sep 17, 2015

@benbalter yep! Examples are in this section of the readme: https://github.com/jch/html-pipeline#3rd-party-extensions. Closing for now, but feel free to send a PR with a link to your project if you build it.

@jch jch closed this as completed Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants