Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List GitHub-deployed versions somewhere? #201

Closed
wking opened this issue Jun 19, 2015 · 1 comment
Closed

List GitHub-deployed versions somewhere? #201

wking opened this issue Jun 19, 2015 · 1 comment

Comments

@wking
Copy link

wking commented Jun 19, 2015

I've been having trouble with the HTML formatting for emailed comment replies. For example, here part my comment is hidden in email-signature-reply div. However, I haven't been able to reproduce this parsing with tests on email_reply_parser (see commit wking/email_reply_parser@bd9571a6, Add tests for indented blocks after quotes, 2015-06-18 in my test-reply branch) or in the repository (see my test-reply branch off this repository). It would help me figure out why the output from this repository (which looks good :) differs from the live HTML I see on GitHub (which has the incorrect email-signature-reply divs) if there was a deployed-version endpoint like there is for GitHub Pages. If that would be leaking to much information, maybe you can compare the deployed versions with what I'm using for tests in my local bundle:

$ bundle show
Gems included by the bundle:
  * RedCloth (4.2.9)
  * activesupport (4.2.2)
  * bundler (1.7.3)
  * charlock_holmes (0.6.9.4)
  * email_reply_parser (0.5.8)
  * escape_utils (0.3.2)
  * gemoji (2.1.0)
  * github-linguist (2.6.7)
  * github-markdown (0.6.8)
  * html-pipeline (1.11.0)
  * i18n (0.7.0)
  * json (1.8.3)
  * mime-types (1.25.1)
  * mini_portile (0.6.2)
  * minitest (5.7.0)
  * nokogiri (1.6.5)
  * posix-spawn (0.3.11)
  * pygments.rb (0.4.2)
  * rake (10.4.2)
  * rinku (1.7.3)
  * sanitize (2.1.0)
  * thread_safe (0.3.5)
  * tzinfo (1.2.2)
  * yajl-ruby (1.1.0)
@jch
Copy link
Contributor

jch commented Aug 4, 2015

@wking sorry for the late reply, I was previously on leave.

html-pipeline is only part of what GitHub uses internally to generate markup. If you're seeing bad email markup, I'd suggest writing in at https://github.com/contact. If I'm misunderstanding what you're asking, please let me know.

Thanks!

@jch jch closed this as completed Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants