Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gemojione instead of gemoji #200

Closed
balasankarc opened this issue Jun 14, 2015 · 2 comments
Closed

Use gemojione instead of gemoji #200

balasankarc opened this issue Jun 14, 2015 · 2 comments
Labels

Comments

@balasankarc
Copy link

Hi,
gemojione is a free licensed collection of emoji. Can html-pipeline use that for EmojiFilter?

I am packaging html-pipeline for Debian as part of GitLab packaging and it hit a roadblock due to the non-free nature of gemoji. It would be a great help if this dependency on gemoji can be removed.

Thanks.

@jch
Copy link
Contributor

jch commented Aug 4, 2015

@balasankarc that's a good suggestion, but would break old versions. Have you considered writing your own filter that depends on gemojione?

@gjtorikian
Copy link
Owner

A new (beta) release of HTML-Proofer has been released, v3.0.0.pre1. I tried to go back and address all the issues in this repo.

gemojione is now a supported dependency through the new require_dependencies method available to filters, which goes down a list of dependencies and selects the first one available:

HTMLPipeline.require_dependencies(["gemoji", "gemojione"], "EmojiFilter")

Repository owner locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants