Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ftp scheme for markdown URLs #187

Closed
Arnavion opened this issue Mar 16, 2015 · 6 comments
Closed

Support ftp scheme for markdown URLs #187

Arnavion opened this issue Mar 16, 2015 · 6 comments

Comments

@Arnavion
Copy link

Currently it's not output as an anchor.

Source: Get foo.txt from [here.](ftp://example.com/foo.txt)

Live: Get foo.txt from here.

@JuanitoFatas
Copy link
Contributor

Hello @Arnavion,

You could add another pipeline to allow more schemes in your application. Please see the rationale behind this in #104 and #39.

Thanks for checking in! 😊

@Arnavion
Copy link
Author

My intention was to have this for github.com

Regarding the security concern:

  1. Major browsers support FTP themselves instead of requiring a separate client.
  2. You support mailto, which does require a separate client, and has a much wider history of causing ACE via buffer overflows (eg: ridiculously long subject lines) in said clients.

@JuanitoFatas JuanitoFatas reopened this Mar 17, 2015
@JuanitoFatas
Copy link
Contributor

/cc @jch

@simeonwillbanks
Copy link
Contributor

@mojavelinux
Copy link
Contributor

Interesting to note that this seems to work fine for AsciiDoc files.

@kerner1000
Copy link

Hey,
this does not work if you include username and password in the link.
E.g.
ftp
(ftp://user:[email protected]/mydata)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants