-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSX HTML::Pipeline::MarkdownFilter Fails on Right Double Quotation Mark around email address #173
Comments
cc/ @gjtorikian @mdiep |
It looks like it is thinking the Right Double Quotation Mark is part of the email address when doing the autolink. This could be related to this bug. vmg/redcarpet#388 |
@ericgoodwin do you have a backtrace of the error? |
Not sure it's much help because there is only one line that isn't Pry, but here it is.
The error can also be created by just using github-markdown as well.
|
Just found out it's an issue with Ruby versions as well. Ruby 2.1.3
Ruby 1.9
It would appear that Ruby 1.9 is converting the characters automatically. |
@ericgoodwin 👍 thanks for digging in. I'm going to close this issue for now because I can't think of anything specific to take action on. If you find more details about the encoding, please continue to comment here. I'm happy to reopen if there is a fix that can be applied against the gem. |
@jch Ok. Wasn't quite sure where to post this in the first place. I might keep on adding a few comments on here if that's ok with you so anyone else who runs into the issue can find some information on it. The issue seems to be with the github-markdown binary. |
👍 Yep keep 'em coming |
When using the
HTML::Pipeline::MarkdownFilter
on a string containing a "Right Double Quotation Mark" (U+201D) around an email address the output html will include an invalid byte sequence when trying to autolink it as amailto:
I'm only having this issue on OSX. I'm running 10.10.2.
To reproduce:
This is really a bug within github-markdown, but I'm submitting it here as github-markdown doesn't seem to have a Github repository. I've also tried using Redcloth and it fails as well.
The text was updated successfully, but these errors were encountered: