Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add "details" tag to whitelist #138

Closed
tansaku opened this issue Sep 2, 2014 · 4 comments
Closed

Feature Request: Add "details" tag to whitelist #138

tansaku opened this issue Sep 2, 2014 · 4 comments

Comments

@tansaku
Copy link
Contributor

tansaku commented Sep 2, 2014

I'm a little surprised that the html5 "summary" tag is whitelisted, but the "details" tag (that it is used with) is not whitelisted:

http://html5doctor.com/the-details-and-summary-elements/

Might it be possible to include the "details" tag in the white list? I think this could be a really useful feature

@jch
Copy link
Contributor

jch commented Sep 3, 2014

Closed by #139

@jch jch closed this as completed Sep 3, 2014
@mganss
Copy link

mganss commented Nov 25, 2014

Are you sure this works as intended? I'm not a Ruby guy, but from the code it looks like you have white-listed an additional attribute, not a tag. The summary attribute that was already there is the summary attribute on the table tag.

@jch
Copy link
Contributor

jch commented Nov 25, 2014

@tansaku @mganss ah dang it, you're right. Should've added a test for this. Would either of you be up for a follow up PR? If not, I'll get around to this in the holidays.

@jch
Copy link
Contributor

jch commented Jan 21, 2015

Closed by #171

@jch jch closed this as completed Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants