Camo Filter doesn't return doc when disabled

[spicycode]

During some testing this morning I started using the disable_asset_proxy option. It seems when you pass that in the CamoFilter just returns nil, instead of the doc causing the rest of the filter chain to break.

[jch]

Hmmm, ya this line https://github.com/jch/html-pipeline/blob/master/lib/html/pipeline/camo_filter.rb#L25 should return doc. I noticed that the disable_asset_proxy option is not currently documented. I'm not sure if disabling filters at runtime is common, but maybe it makes more sense to generalize this functionality at the Pipeline level rather than at the Filter level:

SomePipeline = HTML::Pipeline.new [
  HTML::Pipeline::CamoFilter,
  HTML::Pipeline::MarkdownFilter
]

SomePipeline.call("some input content", :disable_filters => [:camo])

Thoughts?

[spicycode]

@jch At the moment we are using it to disable the filter in enterprise land, but keep it everywhere else. I think a higher level disable filters could be great as well.

[josh]

0e32670

[jch]

@josh thanks for the fix, could you put them in PR's in the future? I like to link to specific PR's in the change logs.

[josh]

Yeah, sorry, it was a quick fix for .com purposes. We just hit the same issue, d'oh! But I kinda agree about just removing the filter if you aren't using it.

[jch]

Closing. Slated for the next release v1.6.0. Waiting on #105 before I cut that.