Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect asset pipeline availability #1

Closed
jch opened this issue Aug 8, 2012 · 5 comments
Closed

Detect asset pipeline availability #1

jch opened this issue Aug 8, 2012 · 5 comments

Comments

@jch
Copy link
Contributor

jch commented Aug 8, 2012

In the github app, the emoji icons are frozen to public/images, and urls to images are coded relative to the value of :asset_root. It'd be preferable to detect the availability of the asset-pipeline and use asset_path when it's available.

@atmos
Copy link
Contributor

atmos commented Oct 3, 2012

Is there any reason this stuff can't be cached in akamai sanely and just shared with everyone?

@jch
Copy link
Contributor Author

jch commented Oct 3, 2012

That'd be useful for most projects, but would give the SSL insecure elements error for some projects. GitHub projects should definitely use the same assets though.

@atmos
Copy link
Contributor

atmos commented Oct 4, 2012

The urls can be hardcoded and delegated to akamai without camo integration and knowing about SSL.

I almost wish we didn't have secret keys in camo. We can't trivially evict shit out of akamai, we can just update the key but tons of older cached links will still live on. :\

@jch
Copy link
Contributor Author

jch commented Oct 4, 2012

But when this becomes opensource, we'll want to give users the option of how to serve assets. Since emoji is the only case, I think it's ok to leave it hardcoded relative to the gem and not support the asset pipeline until someone asks for it. Vote to close?

@atmos atmos closed this as completed Oct 4, 2012
@ghost
Copy link

ghost commented Jan 26, 2015

👍 for asset pipeline support, because as it is now my heroku app is serving static assets (for the emoji filter), instead of having them automagically cached by cloudfront.

PS the asset pipeline instructions in the gemoji readme are out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants