Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement image widget using sixel #213

Open
cjbassi opened this issue Jan 24, 2019 · 4 comments
Open

Reimplement image widget using sixel #213

cjbassi opened this issue Jan 24, 2019 · 4 comments

Comments

@cjbassi
Copy link
Contributor

cjbassi commented Jan 24, 2019

No description provided.

@cjbassi cjbassi added the bug label Jan 24, 2019
@cjbassi cjbassi closed this as completed Jan 24, 2019
@cjbassi cjbassi removed the bug label Jan 24, 2019
@cjbassi cjbassi changed the title Fix image widget Improve image widget rendering speed Jan 24, 2019
@cjbassi cjbassi reopened this Jan 24, 2019
@cjbassi cjbassi changed the title Improve image widget rendering speed Reimplement image widget using libsixel Jan 24, 2019
@cjbassi cjbassi changed the title Reimplement image widget using libsixel Reimplement image widget using sixel Jan 25, 2019
@diamondburned
Copy link

I really want this feature to happen. Is there anything I can do to speed this up?

@cjbassi
Copy link
Contributor Author

cjbassi commented Feb 13, 2019

Hi, thanks for asking. So I'm actually not really familiar with sixel, and I don't even know if we can get it to work with termbox-go (but it would be really nice if we could), so I guess the first step would be to figure out some of this preliminary stuff. We would probably need a Go library for sixel, I just found go-sixel which might work. We also need to figure out if termbox-go will let us draw to the terminal when its running. It usually only accepts unicode characters, not escape sequences, but I'm wondering if we could find a way to draw over it when its running.

So basically, if you want to play around with some of this stuff (including go-sixel) and report back what you find that would be great :D

@diamondburned
Copy link

I did try making a bytes reader and forward that to a TextView or something on termui, but the escape chars are stripped. I also tried playing around with termbox-go, but all the []rune low level stuff was too hard for me. I also tried looking into termbox-go, but I have no idea where they stripped the escape codes. If you could give me an idea on this one, that would be really helpful.

I did, however, try to play around with go-sixel. It worked fine in my forked xterm.

@srlehn
Copy link

srlehn commented Mar 29, 2019

implemented sixel support which needs further testing over at #233.
I hope that someone else finishes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants