GitSpeak locks up when trying to click on a different PR in the list

[jaydiablo]

Hello, recently GitSpeak has been locking up on me when I click PRs in the list.

Here's the error thrown in the console when I try to click and it locks up:

Uncaught TypeError: Cannot read property 'firstSeen' of null
at t.S.userHasSeen (cached-client-31373db5298e14c90d61.js:2573)
at Object.t.render (cached-client-31373db5298e14c90d61.js:3889)
at Object.n.Tag.commit (cached-client-31373db5298e14c90d61.js:30477)
at Object.n.Tag.end (cached-client-31373db5298e14c90d61.js:30483)
at t (cached-client-31373db5298e14c90d61.js:18916)
at Object.t.render (cached-client-31373db5298e14c90d61.js:18916)
at Object.t.setup (cached-client-31373db5298e14c90d61.js:18843)
at Object.n.Tag.end (cached-client-31373db5298e14c90d61.js:30482)
at Object.t.render (cached-client-31373db5298e14c90d61.js:19509)
at Object.n.Tag.commit (cached-client-31373db5298e14c90d61.js:30477)

Here's the whole stack:

S.userHasSeen @ cached-client-31373d…98e14c90d61.js:2573
t.render @ cached-client-31373d…98e14c90d61.js:3889
n.Tag.commit @ cached-client-31373d…8e14c90d61.js:30477
n.Tag.end @ cached-client-31373d…8e14c90d61.js:30483
t @ cached-client-31373d…8e14c90d61.js:18916
t.render @ cached-client-31373d…8e14c90d61.js:18916
t.setup @ cached-client-31373d…8e14c90d61.js:18843
n.Tag.end @ cached-client-31373d…8e14c90d61.js:30482
t.render @ cached-client-31373d…8e14c90d61.js:19509
n.Tag.commit @ cached-client-31373d…8e14c90d61.js:30477
n.Tag.end @ cached-client-31373d…8e14c90d61.js:30483
t @ cached-client-31373d…8e14c90d61.js:19516
t.render @ cached-client-31373d…8e14c90d61.js:19516
n.Tag.commit @ cached-client-31373d…8e14c90d61.js:30477
n.Tag.end @ cached-client-31373d…8e14c90d61.js:30483
t.body @ cached-client-31373d…8e14c90d61.js:20145
t.renderNode @ cached-client-31373d…98e14c90d61.js:3441
t.render @ cached-client-31373d…98e14c90d61.js:3890
t.render @ cached-client-31373d…8e14c90d61.js:20143
n.Tag.commit @ cached-client-31373d…8e14c90d61.js:30477
n.Tag.end @ cached-client-31373d…8e14c90d61.js:30483
S.Issue.sheet @ cached-client-31373d…98e14c90d61.js:2881
t.dataDidSet @ cached-client-31373d…8e14c90d61.js:18578
t.setData @ cached-client-31373d…8e14c90d61.js:18567
n.Tag.bindData @ cached-client-31373d…8e14c90d61.js:30410
t.render @ cached-client-31373d…8e14c90d61.js:19955
n.Tag.commit @ cached-client-31373d…8e14c90d61.js:30477
n.Tag.end @ cached-client-31373d…8e14c90d61.js:30364
t.render @ cached-client-31373d…8e14c90d61.js:19635
n.Tag.commit @ cached-client-31373d…8e14c90d61.js:30477
n.Tag.end @ cached-client-31373d…8e14c90d61.js:30364
t.render @ cached-client-31373d…8e14c90d61.js:18491
t.tick @ cached-client-31373d…8e14c90d61.js:18480
n.Scheduler.flush @ cached-client-31373d…8e14c90d61.js:30984
n.Scheduler.tick @ cached-client-31373d…8e14c90d61.js:30989
a.tick @ cached-client-31373d…8e14c90d61.js:30921
t._ticker @ cached-client-31373d…8e14c90d61.js:30906
requestAnimationFrame (async)
a.schedule @ cached-client-31373d…8e14c90d61.js:30926
a.add @ cached-client-31373d…8e14c90d61.js:30913
n.Scheduler.requestTick @ cached-client-31373d…8e14c90d61.js:30992
n.Scheduler.mark @ cached-client-31373d…8e14c90d61.js:30982
n.Scheduler.onevent @ cached-client-31373d…8e14c90d61.js:31009
o @ cached-client-31373d…298e14c90d61.js:466
r.emit @ cached-client-31373d…298e14c90d61.js:485
n.commit @ cached-client-31373d…8e14c90d61.js:30936
n.Event.processed @ cached-client-31373d…8e14c90d61.js:30101
n.Event.process @ cached-client-31373d…8e14c90d61.js:30098
n.EventManager.trigger @ cached-client-31373d…8e14c90d61.js:29987
n.Tag.trigger @ cached-client-31373d…8e14c90d61.js:30534
t.ontap @ cached-client-31373d…8e14c90d61.js:18679
n.Event.process @ cached-client-31373d…8e14c90d61.js:30098
(anonymous) @ cached-client-31373d…8e14c90d61.js:29964

Once the error is thrown I can't really do anything else in the app unless I restart.

This is with version Version 0.2.34 (0.2.34.148) on macOS 10.15.6.

[jaydiablo]

I cloned this repo (master branch) and ran npm install then npm audit fix (as there were a number of deps that had security vulnerabilities) then ran npm run start and the launched app doesn't seem to exhibit the same behavior.

Perhaps the issue is in a dependency that was fixed?

[jaydiablo]

The built app (mac) seems to have the issue though 🤷