Open Changes (with difftool) opens one difftool window per changed file.

[phindle]

• GitLens Version: 8.5.6
• VSCode Version: 1.27.1
• OS Version: Windows 10 Pro (1803)

Steps to Reproduce:

1. Have a project open with 2 files (.cs files) modified.
2. Invoke 'GitLens: Open Changes (with difftool)' from the command palette (or use Alt+M keyboard shortcut)
3. P4Merge (my configured diff tool) opens twice, one for each modified file.

Expected outcome:
Using Open Changes (with difftool) should only difftool the currently open editor.

p.s. Thank you Eric - GitLens is brilliant!

[eamodio]

Thanks! 😄 Yeah, that command isn't working properly in that case.

[kaiseiken]

This change actually appears to have removed a second option "Open All Changes (with difftool)", which had the expected outcome that @phindle desired.

"Open Changes (with difftool)" appears to behave exactly how the original bug describes, which was probably not a bug to begin with. But now, with no option to use the previous "Open All Changes (with difftool)" command, that functionality is missing.

Oddly enough, it looks like you can still assign a keyboard shortcut to "Open All Changes (with difftool)", but it merely invokes the "Open Changes (with difftool)".

[kaiseiken]

I was testing this functionality using Meld on Linux and Windows, which supports file comparisons and directory comparisons. I believe this is the difference between the two difftool commands as previously implemented.

[eamodio]

@kaiseiken Thanks for the report -- would you mind opening a new issue for this Open All Changes (with difftool) missing or not working?

[kaiseiken]

Sure, no prob.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.