chore: remove lodash

Author: afonsojramos

package.json

@@ -100,7 +100,6 @@
     "electron-updater": "6.1.4",
     "final-form": "4.20.10",
     "history": "4.10.1",
-    "lodash": "4.17.21",
     "menubar": "9.3.0",
     "nprogress": "0.2.0",
     "react": "18.2.0",
@@ -117,7 +116,6 @@
     "@testing-library/react": "14.0.0",
     "@testing-library/react-hooks": "8.0.1",
     "@types/jest": "29.5.5",
-    "@types/lodash": "4.14.199",
     "@types/node": "18.18.0",
     "@types/react": "18.2.28",
     "@types/react-router-dom": "5.3.3",

pnpm-lock.yaml

@@ -1,5 +1,4 @@
 import React from 'react';
-import _ from 'lodash';
 import { ChevronDownIcon, ChevronLeftIcon } from '@primer/octicons-react';
 
 import { Notification } from '../typesGithub';
@@ -14,10 +13,21 @@ interface IProps {
 export const AccountNotifications = (props: IProps) => {
   const { hostname, showAccountHostname, notifications } = props;
 
-  const groupedNotifications = _(notifications)
-    .groupBy((obj) => obj.repository.full_name)
-    .sortBy((_, key) => key)
-    .value();
+  const groupedNotifications = Object.values(
+    notifications.reduce(
+      (acc: { [key: string]: Notification[] }, notification) => {
+        const key = notification.repository.full_name;
+        if (!acc[key]) {
+          acc[key] = [];
+        }
+        acc[key].push(notification);
+        return acc;
+      },
+      {},
+    ),
+  ).sort((a, b) =>
+    a[0].repository.full_name.localeCompare(b[0].repository.full_name),
+  );
 
   const Chevron = notifications.length > 0 ? ChevronDownIcon : ChevronLeftIcon;
 

src/components/AccountNotifications.tsx

@@ -1,4 +1,3 @@
-import * as _ from 'lodash';
 import { ipcRenderer } from 'electron';
 
 import { generateGitHubWebUrl, getCommentId } from './helpers';

src/utils/notifications.test.ts

@@ -1,5 +1,3 @@
-import * as _ from 'lodash';
-
 import {
   mockedSingleAccountNotifications,
   mockedSingleNotification,

src/utils/remove-notification.test.ts

@@ -1,7 +1,4 @@
-import updateWith from 'lodash/updateWith';
-
 import { AccountNotifications } from '../types';
-import { Notification } from '../typesGithub';
 
 export const removeNotification = (
   id: string,
@@ -12,11 +9,16 @@ export const removeNotification = (
     (accountNotifications) => accountNotifications.hostname === hostname,
   );
 
-  return updateWith(
-    [...notifications],
-    `[${accountIndex}][notifications]`,
-    (accNotifications: Notification[] = []) => {
-      return accNotifications.filter((notification) => notification.id !== id);
-    },
-  );
+  if (accountIndex !== -1) {
+    const updatedNotifications = [...notifications];
+    updatedNotifications[accountIndex] = {
+      ...updatedNotifications[accountIndex],
+      notifications: updatedNotifications[accountIndex].notifications.filter(
+        (notification) => notification.id !== id,
+      ),
+    };
+    return updatedNotifications;
+  }
+
+  return notifications;
 };

src/utils/remove-notification.ts

@@ -1,7 +1,4 @@
-import updateWith from 'lodash/updateWith';
-
 import { AccountNotifications } from '../types';
-import { Notification } from '../typesGithub';
 
 export const removeNotifications = (
   repoSlug: string,
@@ -12,13 +9,16 @@ export const removeNotifications = (
     (accountNotifications) => accountNotifications.hostname === hostname,
   );
 
-  return updateWith(
-    [...notifications],
-    `[${accountIndex}][notifications]`,
-    (accNotifications: Notification[] = []) => {
-      return accNotifications.filter(
+  if (accountIndex !== -1) {
+    const updatedNotifications = [...notifications];
+    updatedNotifications[accountIndex] = {
+      ...updatedNotifications[accountIndex],
+      notifications: updatedNotifications[accountIndex].notifications.filter(
         (notification) => notification.repository.full_name !== repoSlug,
-      );
-    },
-  );
+      ),
+    };
+    return updatedNotifications;
+  }
+
+  return notifications;
 };