build(biome): enable noConsoleLog rule (#1268)

* build(biome): enable noConsoleLog rule

* extract into fns

* extract into fns

Author: setchy

biome.json

@@ -7,6 +7,9 @@
     "enabled": true,
     "rules": {
       "recommended": true,
+      "suspicious": {
+        "noConsoleLog": "error"
+      },
       "nursery": {
         "noUnusedFunctionParameters": "error",
         "useDefaultSwitchClause": "error"

scripts/notarize.js

@@ -3,20 +3,25 @@ const { notarize } = require('@electron/notarize');
 const packageJson = require('../package.json');
 const appBundleId = packageJson.build.appId;
 
+function logNotarizingProgress(msg) {
+  // biome-ignore lint/suspicious/noConsoleLog: log notarizing progress
+  console.log(`  • notarizing        ${msg}`);
+}
+
 const notarizeApp = async (context) => {
   const { electronPlatformName, appOutDir } = context;
   const appName = context.packager.appInfo.productFilename;
   const isMacOS = electronPlatformName === 'darwin';
   const shouldNotarize = process.env.NOTARIZE === 'true';
 
   if (!shouldNotarize || !isMacOS) {
-    console.log(
-      '  • notarizing      either should not notarize or not building for macOS',
+    logNotarizingProgress(
+      'either should not notarize or not building for macOS',
     );
     return;
   }
 
-  console.log('  • notarizing      started');
+  logNotarizingProgress('process started');
 
   return await notarize({
     appBundleId,

src/utils/auth/migration.ts

@@ -3,6 +3,11 @@ import Constants from '../constants';
 import { loadState, saveState } from '../storage';
 import { getUserData } from './utils';
 
+export function logMigrationProgress(msg: string) {
+  // biome-ignore lint/suspicious/noConsoleLog: log migration progress
+  console.log(`Account Migration: ${msg}`);
+}
+
 /**
  * Migrate authenticated accounts from old data structure to new data structure (v5.7.0+).
  *
@@ -12,15 +17,15 @@ export async function migrateAuthenticatedAccounts() {
   const existing = loadState();
 
   if (hasAccountsToMigrate(existing.auth)) {
-    console.log('Commencing authenticated accounts migration');
+    logMigrationProgress('Commencing authenticated accounts migration');
 
     const migratedAccounts = await convertAccounts(existing.auth);
 
     saveState({
       auth: { ...existing.auth, accounts: migratedAccounts },
       settings: existing.settings,
     });
-    console.log('Authenticated accounts migration complete');
+    logMigrationProgress('Authenticated accounts migration complete');
   }
 }