Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commenting on unchanged lines in a pull request #347

Closed
github-product-roadmap opened this issue Dec 15, 2021 · 1 comment
Closed

Commenting on unchanged lines in a pull request #347

github-product-roadmap opened this issue Dec 15, 2021 · 1 comment
Labels
all Product SKU: All cloud Available on Cloud exploring Feature phase: Exploring ga Feature phase: Generally available pull requests Feature: Github Pull Requests server Available on Server

Comments

@github-product-roadmap
Copy link
Collaborator

Summary

Review comments are the primary way reviewers provide feedback to the author and other reviewers during the review phase of a pull request, but currently comments can only be added to the 3 lines before or after a changed line. We intend to allow users to add comments and suggest changes on any line in any file changed in the pull request.

image

Intended Outcome

This will improve the review experience and increase review quality by allowing users to comment on lines that were not changed (but maybe should have been). Users will no longer need to add a comment to a random changed line and reference a line number when providing feedback about missing a change.

How will it work?

A users can add a comment, reply to a comment, or suggest changes to any line of a changed file, not just the 3 lines surrounding a change.

@github github locked and limited conversation to collaborators Dec 15, 2021
@github-product-roadmap github-product-roadmap added all Product SKU: All cloud Available on Cloud code ga Feature phase: Generally available labels Dec 15, 2021
@Sid-ah Sid-ah moved this to Q1 2022 – Jan-Mar in GitHub Public Roadmap Dec 15, 2021
@alexcnichols alexcnichols moved this from Q1 2022 – Jan-Mar to Q4 2022 – Oct-Dec in GitHub Public Roadmap Apr 13, 2022
@github-product-roadmap github-product-roadmap added the server Available on Server label May 18, 2022
@ankneis ankneis added the pull requests Feature: Github Pull Requests label Dec 21, 2022
@ankneis ankneis moved this from Q4 2022 – Oct-Dec to Future in GitHub Public Roadmap May 8, 2023
@github-product-roadmap github-product-roadmap added the exploring Feature phase: Exploring label May 10, 2023
@ankneis
Copy link
Collaborator

ankneis commented Nov 20, 2024

Please continue to refer to our updated Public Roadmap for the latest ships, including updates on the continuation of these projects. For more information, please check out this Discussion post.

@ankneis ankneis closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
all Product SKU: All cloud Available on Cloud exploring Feature phase: Exploring ga Feature phase: Generally available pull requests Feature: Github Pull Requests server Available on Server
Projects
Status: Future
Development

No branches or pull requests

2 participants