From 0ca1dfc9061daf7410b2475f5b33003360394109 Mon Sep 17 00:00:00 2001 From: dontstopbelieveing Date: Sat, 9 Mar 2024 13:08:50 -0800 Subject: [PATCH 1/2] Update description for max-lag-millis in command-line-flags.md --- doc/command-line-flags.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/command-line-flags.md b/doc/command-line-flags.md index ac491b268..5c0080eb5 100644 --- a/doc/command-line-flags.md +++ b/doc/command-line-flags.md @@ -190,6 +190,8 @@ When using [Connect to replica, migrate on master](cheatsheet.md#a-connect-to-re When [`--throttle-control-replicas`](#throttle-control-replicas) is provided, throttling also considers lag on specified hosts. Lag measurements on listed hosts is done by querying `gh-ost`'s _changelog_ table, where `gh-ost` injects a heartbeat. +When using on master or when [--allow-on-master] is provided, max-lag-millis is also considered a threshold for starting the cutover stage of the migration. If the row copy is complete and the heartbeat lag is less than max-lag-millis cutover phase of the migration will start. + See also: [Sub-second replication lag throttling](subsecond-lag.md) ### max-load From c55c34d73cb505e391ad23fc5bc0ebafc7a57cb8 Mon Sep 17 00:00:00 2001 From: dontstopbelieveing Date: Sat, 9 Mar 2024 13:12:08 -0800 Subject: [PATCH 2/2] Update command-line-flags.md --- doc/command-line-flags.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/command-line-flags.md b/doc/command-line-flags.md index 5c0080eb5..d2ec7137d 100644 --- a/doc/command-line-flags.md +++ b/doc/command-line-flags.md @@ -190,7 +190,7 @@ When using [Connect to replica, migrate on master](cheatsheet.md#a-connect-to-re When [`--throttle-control-replicas`](#throttle-control-replicas) is provided, throttling also considers lag on specified hosts. Lag measurements on listed hosts is done by querying `gh-ost`'s _changelog_ table, where `gh-ost` injects a heartbeat. -When using on master or when [--allow-on-master] is provided, max-lag-millis is also considered a threshold for starting the cutover stage of the migration. If the row copy is complete and the heartbeat lag is less than max-lag-millis cutover phase of the migration will start. +When using on master or when `--allow-on-master` is provided, `max-lag-millis` is also considered a threshold for starting the cutover stage of the migration. If the row copy is complete and the heartbeat lag is less than `max-lag-millis` cutover phase of the migration will start. See also: [Sub-second replication lag throttling](subsecond-lag.md)