Skip to content

Commit b501353

Browse files
committed
Revert "Improve signature detection, so that lines with delimiters in the middle of the line don't get interpreted as beginning of signature."
This reverts commit 1e8a064.
1 parent 1e8a064 commit b501353

File tree

3 files changed

+1
-13
lines changed

3 files changed

+1
-13
lines changed

lib/email_reply_parser.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ def read(text)
133133

134134
private
135135
EMPTY = "".freeze
136-
SIGNATURE = '(?m)^(--|__|\w-$)|(^(\w+\s*){1,3} ym morf tneS$)'
136+
SIGNATURE = '(?m)(--|__|\w-$)|(^(\w+\s*){1,3} ym morf tneS$)'
137137

138138
begin
139139
require 're2'

test/email_reply_parser_test.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -167,11 +167,6 @@ def test_pathological_emails
167167
assert (Time.now - t0) < 1, "Took too long, upgrade to re2 gem."
168168
end
169169

170-
def test_doesnt_remove_signature_delimiter_in_mid_line
171-
reply = email(:email_sig_delimiter_in_middle_of_line)
172-
assert_equal 1, reply.fragments.size
173-
end
174-
175170
def email(name)
176171
body = IO.read EMAIL_FIXTURE_PATH.join("#{name}.txt").to_s
177172
EmailReplyParser.read body

test/emails/email_sig_delimiter_in_middle_of_line.txt

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)