Update to newer azure/login action using node16

[muzimuzhi]

Code of Conduct

• I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?

It's about the workflow files in .github/workflows directory. Sorry I didn't find a better issue template to report this.

What part(s) of the article would you like to see updated?

I noticed the workflow run https://github.com/github/docs/actions/runs/4737193099 throws a warning

Build and deploy Azure preview environment
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: azure/login@1f63701bf3e6892515f1b7ce2d2bf1708b46beaf. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

• azure/login@1f63701bf3e6892515f1b7ce2d2bf1708b46beaf corresponds to v1.4.3.
• The least version using node16 is v1.4.5, Azure/login@24848bc.
• The latest release is v1.4.6, Azure/login@92a5484.

So the SHA-ref could be upgraded to either

• azure/login@24848bc889cfc0a8313c2b3e378ac0d625b9bc16 for v1.4.5 or
• azure/login@92a5484dfaf04ca78a94597f4f19fea633851fa2 for v1.4.6

Note azure/login@1f63701bf3e6892515f1b7ce2d2bf1708b46beaf is used in six workflow files, and that's all uses of azure/login in .github/workflows.

grep -rn 'azure/login@1f63701' .github
.github/workflows/azure-staging-build-deploy.yml:48:        uses: azure/login@1f63701bf3e6892515f1b7ce2d2bf1708b46beaf
.github/workflows/translation-health-report.yml:97:        uses: azure/login@1f63701bf3e6892515f1b7ce2d2bf1708b46beaf
.github/workflows/main-preview-docker-cache.yml:33:        uses: azure/login@1f63701bf3e6892515f1b7ce2d2bf1708b46beaf
.github/workflows/azure-prod-build-deploy.yml:37:        uses: azure/login@1f63701bf3e6892515f1b7ce2d2bf1708b46beaf
.github/workflows/azure-preview-env-deploy.yml:74:        uses: azure/login@1f63701bf3e6892515f1b7ce2d2bf1708b46beaf
.github/workflows/azure-preview-env-destroy.yml:38:        uses: azure/login@1f63701bf3e6892515f1b7ce2d2bf1708b46beaf

Additional information

No response

[cmwilson21]

@muzimuzhi Thanks for opening an issue. We did just merge a big PR that updates to node16. Can you confirm that your issue is covered here?

Thanks again for your interest in improving the docs! 💖

[muzimuzhi]

@cmwilson21 Unfortunately no, the #24540 you mentioned only updates node12 action usages in files in directories content, contributing, and data/reusables, aka in doc examples. Current issue reports node12 action usages in files in directory .github/workflows, aka the workflow files used by this repo itself.

Actually I did see #24540 before opening current issue. I should mention it at the first time.

[muzimuzhi]

So the SHA-ref could be upgraded to either

• azure/login@24848bc889cfc0a8313c2b3e378ac0d625b9bc16 for v1.4.5 or
• azure/login@92a5484dfaf04ca78a94597f4f19fea633851fa2 for v1.4.6

I'd like to leave the decision (upgrade to which version? though from release notes the difference is minimal) to the GitHub docs team/maintainers, hence didn't open a PR.

[heiskr]

I've opened an internal pull request to update; due to security policy we can't accept workflow changes in the open source repository

[cmwilson21]

@muzimuzhi Thanks for coming back and confirming! And thanks again for opening the issue 💖

@heiskr Thanks for taking care of this one internally! 👍

[cmwilson21]

Closing this one out as it has been taken care of internally 💛

[muzimuzhi]

Just for the info, it's resolved by aad2cef.