Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify automatic creation of inactive statuses is for same environment #2429

Closed
bradymholt opened this issue Dec 29, 2020 · 1 comment · Fixed by #2430
Closed

Clarify automatic creation of inactive statuses is for same environment #2429

bradymholt opened this issue Dec 29, 2020 · 1 comment · Fixed by #2430
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team

Comments

@bradymholt
Copy link
Contributor

What is the current behavior?

The Inactive deployments section of the REST Reference docs mentions:

When you set the state of a deployment to success, then all prior non-transient, non-production environment deployments in the same repository will become inactive.

But, this only happens for previous deployments with the same environment name, as noted in this Changelog: https://developer.github.com/changes/2016-04-06-deployment-and-deployment-status-enhancements/#automatic-creation-of-inactive-statuses

What changes are you suggesting?

Clarify that automatic creation of inactive statuses is made to deployments with the same environment name.

Additional information

(none)

@bradymholt bradymholt added the engineering Will involve Docs Engineering label Dec 29, 2020
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 29, 2020
@chiedo chiedo removed the engineering Will involve Docs Engineering label Jan 4, 2021
@chiedo
Copy link
Contributor

chiedo commented Jan 4, 2021

@janiceilene this looks like a content change!

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team and removed triage Do not begin working on this issue until triaged by the team labels Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants