Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a Docker actions incorrectly stating that you must declare inputs #15210

Closed
1 task done
nikola-jokic opened this issue Feb 7, 2022 · 2 comments · Fixed by #15768
Closed
1 task done

Creating a Docker actions incorrectly stating that you must declare inputs #15210

nikola-jokic opened this issue Feb 7, 2022 · 2 comments · Fixed by #15768
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team

Comments

@nikola-jokic
Copy link
Contributor

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action

What part(s) of the article would you like to see updated?

In the section Creating an action metadata file, it is stated that you need to specify inputs in order to pass them to the container. This is not exactly the case which is explained in runner issue #499. If you use with.args, arguments will be passed to the entrypoint regardless of input spec.
This is explained well in this part of the documentation but contradicts a bit with the part I am opening an issue for.
Screenshot 2022-02-07 at 17 18 58

Note that this last part, . /env ; docker ... is taken from issue#499

Additional information

You can refer to my example in test repository. Please note that in actions.yaml, there were no specified inputs, but if you pass inputs using with.args, they will be passed to the container. So this should be added to the docs as well.

@nikola-jokic nikola-jokic added the content This issue or pull request belongs to the Docs Content team label Feb 7, 2022
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 7, 2022
@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 7, 2022
@ramyaparimi
Copy link
Contributor

@nikola-jokic
Thanks so much for opening an issue! I'll triage this for the team to take a look 👀

@nikola-jokic
Copy link
Contributor Author

Hi @ramyaparimi,

Let me know if the team agrees, so I can work on a PR as well 😊

@ramyaparimi ramyaparimi removed the waiting for review Issue/PR is waiting for a writer's review label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants