C#: Change extractor to accept multiple binlog files
#17955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
force-pushed
the
binlog/multiple
branch
from
bbb8f57
to
fe62900
Compare
hvitved
reviewed
Nov 11, 2024
| { | ||
| case ExitCode.Ok: | ||
| case ExitCode.Errors: | ||
| allFailed &= false; |
There was a problem hiding this comment.
Why not simply allFailed = false?
| break; | ||
| } | ||
| } | ||
| return allFailed ? ExitCode.Failed : ExitCode.Ok; |
There was a problem hiding this comment.
What's the motivation for returning ExitCode.Failed only when all analyses failed instead of just a single failure?
There was a problem hiding this comment.
I don't remember any longer why I opted for this originally.
hvitved
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the C# extractor to support multiple binary log files for analysis.
The improvement was requested in #16346 (comment).