C#: Add binlog support to buildless #16672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
force-pushed
the
buildless/binary-log-extractor
branch
5 times, most recently
from
339b2f0
to
b8345b9
Compare
tamasvajk
commented
Jun 4, 2024
csharp/extractor/Semmle.Extraction.CSharp/Extractor/Extractor.cs
Outdated
Show resolved
Hide resolved
tamasvajk
commented
Jun 4, 2024
| var options = Options.CreateWithEnvironment(args); | ||
| if (options.BinaryLogPath is string binlogPath) | ||
| { | ||
| using var fileStream = new FileStream(binlogPath, FileMode.Open, FileAccess.Read, FileShare.Read); |
There was a problem hiding this comment.
We should expect this to fail, and log it nicely.
tamasvajk
force-pushed
the
buildless/binary-log-extractor
branch
from
2e20753
to
0b8b829
Compare
This adds a new option to the driver, `--binlog`. When this is specified the driver will read all C# invocations from the binary log and process them.
tamasvajk
force-pushed
the
buildless/binary-log-extractor
branch
from
d88074c
to
38660a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.