Skip to content

Check disk usage using Node.js API #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 28, 2025
Merged

Check disk usage using Node.js API #3247

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
239e305
Check disk usage using Node.js API
henrymercer Oct 27, 2025
57c7b6a
Disable SIP disablement check
henrymercer Oct 28, 2025
fe16891
Add unit test for `checkDiskUsage`
henrymercer Oct 28, 2025
55895ef
Stub `GITHUB_WORKSPACE` in test
henrymercer Oct 28, 2025
d4ba404
Tweak assertions
henrymercer Oct 28, 2025
66459ea
Apply suggestion
henrymercer Oct 28, 2025
4256e2e
Merge branch 'main' into henrymercer/disk-usage-node-api
henrymercer Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/util.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,3 +534,12 @@ test("getCgroupCpuCountFromCpus returns undefined if the CPU file exists but is
);
});
});

test("checkDiskUsage succeeds and produces positive numbers", async (t) => {
const diskUsage = await util.checkDiskUsage(getRunnerLogger(true));
t.true(
diskUsage?.numAvailableBytes !== undefined &&
diskUsage.numAvailableBytes > 0,
);
t.true(diskUsage?.numTotalBytes !== undefined && diskUsage.numTotalBytes > 0);
Copy link
Member

@mbg mbg Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but I quite like t.truthy in an if condition that guards the check on the property. The && makes it harder to debug which sub-condition failed.

Copy link
Contributor Author

@henrymercer henrymercer Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to write because we can't compare undefined with 0. I'll make two separate assertions.

});
Loading