Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M (MUMPS) syntax highlighting doesn't work in Markdown #1468

Closed
daugeldauge opened this issue Aug 18, 2014 · 8 comments
Closed

M (MUMPS) syntax highlighting doesn't work in Markdown #1468

daugeldauge opened this issue Aug 18, 2014 · 8 comments

Comments

@daugeldauge
Copy link

This is the test repo:
https://github.com/daugeldauge/mtest
As your see, MUMPS syntax highlighting works fine in the source file. But it doesn't work in README.md. Neither with M keyword nor with mumps.

@daugeldauge
Copy link
Author

Or is it markdown engine issue?
I'm not sure.

@pchaigno
Copy link
Contributor

The lexer for M is the same as for Common Lisp. So if you use lisp as keyword it will work:

set cna = ##class(CNA.CNA).%New("путь к libcna") ; Создаем объект класса CNA.CNA. В аргументах указываем путь к libcna.dll или libcna.so
do  cna.LoadLibrary("путь к libtest")            ; Загружаем библиотеку libtest в CNA

@arfon If we add ace_mode: m to the M entry in languages.yml will it fix this problem? (I've never really understood what is the ace_mode entry...)

@daugeldauge daugeldauge changed the title M (MUMPS) syntax higlighting doesn't work in Markdown M (MUMPS) syntax highlighting doesn't work in Markdown Aug 18, 2014
@arfon
Copy link
Contributor

arfon commented Sep 3, 2014

@pchaigno I'm pretty sure the ace_mode is just used on Gist although I'm not entirely sure where 😕

@bkeepers
Copy link
Contributor

bkeepers commented Sep 3, 2014

ace_mode is used for the ace editor on gist (but not on github.com yet). /cc @gjtorikian

This wouldn't have any effect on the markdown rendering. I'm not really sure why it's not working properly in markdown. :(

@pchaigno
Copy link
Contributor

pchaigno commented Sep 4, 2014

I imagine that Linguist uses the alias for the lexers from Pygments as the source for the keywords to use in the mardown rendering. Since M doesn't have a lexer it doesn't work. We would need to explicitly define somewhere m and mumps as keywords for the mardown rendering.

@pchaigno
Copy link
Contributor

pchaigno commented Oct 2, 2014

We would need to explicitly define somewhere m and mumps as keywords for the mardown rendering.

@bkeepers I think it's an issue for the GitHub repository which renders Markdown documents. Would it be possible to open it there and close this one?

@bkeepers
Copy link
Contributor

bkeepers commented Oct 2, 2014

This is actually an issue with the SyntaxHighlightFilter in html-pipeline, which does not use linguist to determine which lexer to use.

@pchaigno
Copy link
Contributor

pchaigno commented Oct 2, 2014

I opened two issues at jch/html-pipeline to solve this: gjtorikian/html-pipeline#152 and gjtorikian/html-pipeline#153.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants