Fix errors when components contain multi-byte characters #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
force-pushed
the
fix-byte-issues
branch
2 times, most recently
from
51da295 to
7e88f2a
Compare
patricklx
commented
Mar 15, 2024
| @@ -472,10 +472,76 @@ exports[`config > semi: false > it formats ../cases/gts/issue-191-b.gts 1`] = ` | |||
|
|
|||
| exports[`config > semi: false > it formats ../cases/gts/issue-191-c.gts 1`] = ` | |||
| "const one = <template>💩💩💩💩💩💩💩</template> | |||
|
|
|||
There was a problem hiding this comment.
the original code also has a line between the const two = .... I think the behaviour from prettier is to keep the line if one is there
patricklx
force-pushed
the
fix-byte-issues
branch
from
7e88f2a to
05af59f
Compare
patricklx
force-pushed
the
fix-byte-issues
branch
from
05af59f to
b3e3bbf
Compare
gitKrystan
approved these changes
Mar 15, 2024
|
Thank you! What a relief. |
gitKrystan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is similar to the fix we did for ember-eslint-parser
fixes #191
closes #220